Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flicker of colour change on the deal ticket button #6974

Open
JonRay15 opened this issue Sep 20, 2024 · 2 comments · Fixed by #6976 or #7006
Open

Flicker of colour change on the deal ticket button #6974

JonRay15 opened this issue Sep 20, 2024 · 2 comments · Fixed by #6976 or #7006
Assignees

Comments

@JonRay15
Copy link
Contributor

The Chore

Probably where we're checking for a balance to decide whether to show DEPOSIT or PLACE ORDER there's a momentary flicker of blue to green while it fetches the balance I guess.

We need to add like a subdued spinner state or something to avoid that or just dont show the button at all until we've fetched.

Tasks

  • [ ]
  • [ ]

Additional details / background info

@JonRay15
Copy link
Contributor Author

JonRay15 commented Oct 1, 2024

There's still an annoying flicker.

It is not the button which now stays green, but I think the text still appears briefly that says "you need to deposit etc" which pushes the button down for a split second before it snaps back up.

@JonRay15
Copy link
Contributor Author

JonRay15 commented Oct 8, 2024

I'm pretty sure this still doesnt work.... at least not on the Nebula githash e91243c

Should it?

@JonRay15 JonRay15 reopened this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: InProg
3 participants