Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Russian translation #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MrKalach
Copy link

No description provided.

@vercel
Copy link

vercel bot commented Mar 31, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/valstu/korona/pnmiqzjmc
✅ Preview: https://korona-git-fork-mrkalach-rutranslation.valstu.now.sh

@MrKalach
Copy link
Author

MrKalach commented Apr 1, 2020

Hey @valstu!
Any chance to merge it?

@valstu
Copy link
Owner

valstu commented Apr 1, 2020

Yeah, this looks good, we added few new translation keys for the bubble chart yesterday so those could be added. I just need to figure out a way to show all these translations since there are 3 other PRs waiting and the current language selecter needs to be restyled.

@MrKalach
Copy link
Author

MrKalach commented Apr 1, 2020

Maybe move all translations to separate files to utils/translations/{LANG}-translation.ts? Then dynamically include them (not sure, is it possible in TS)? Every include could itself add data to global phrases: { [key: string]: { [key: string]: string } } ?

ps. I'm very far from TS and web dev. And maybe my ^^^ proposal is so stupid :)

@MrKalach
Copy link
Author

MrKalach commented Apr 3, 2020

@valstu I did update the PR. Conflicts fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants