Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refacting the vala doc #50

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Refacting the vala doc #50

wants to merge 13 commits into from

Conversation

nda-cunh
Copy link

@nda-cunh nda-cunh commented Oct 2, 2024

add missing documentation and exemple

@nda-cunh nda-cunh marked this pull request as draft October 2, 2024 13:51

.. code-block:: vala

public static int main(string[] args) {
stdout.printf("Hello, World\n");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for beginners I think just print() is better. Then there can be a note explaining that in actual projects people prefer stdout.printf() and why, maybe in the section also where the different main() variants are explained

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine with me, I agree, to show the world that à la is easy to write! 😎

@colinkiama
Copy link
Member

You've done amazing work however, the title suggests that there's only refactoring going on. I see that some brand new content is being added too.

Once you've pushed all the changes here that you want to do, can you split this merge request into multiple smaller merge requests please?

This way, we can get the content reviewed and merged in much faster! ;)

@nda-cunh
Copy link
Author

You've done amazing work however, the title suggests that there's only refactoring going on. I see that some brand new content is being added too.

Once you've pushed all the changes here that you want to do, can you split this merge request into multiple smaller merge requests please?

This way, we can get the content reviewed and merged in much faster! ;)

I'm terrible at choosing names for MR titles! I haven't finished yet, so I'm going to add some pages on partial class
can you help me find another name?

@colinkiama
Copy link
Member

Your commit titles can be used as the pull request titles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants