Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent concurrent IWANT of the same message #943

Merged
merged 5 commits into from
Aug 21, 2023
Merged

Prevent concurrent IWANT of the same message #943

merged 5 commits into from
Aug 21, 2023

Conversation

diegomrsantos
Copy link
Contributor

@diegomrsantos diegomrsantos commented Aug 18, 2023 •
edited
Loading

closes #868

@codecov
Copy link

codecov bot commented Aug 18, 2023 •
edited
Loading

Codecov Report

Merging #943 (bee4b45) into unstable (56c23a2) will decrease coverage by 0.02%.
Report is 3 commits behind head on unstable.
The diff coverage is 95.45%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           unstable     #943      +/-   ##
============================================
- Coverage     83.51%   83.50%   -0.02%     
============================================
  Files            91       91              
  Lines         15145    15160      +15     
============================================
+ Hits          12649    12660      +11     
- Misses         2496     2500       +4
Files Changed Coverage Δ
libp2p/protocols/pubsub/gossipsub/behavior.nim 88.83% <91.66%> (+0.43%) ⬆️
libp2p/protocols/pubsub/gossipsub.nim 86.76% <100.00%> (-0.25%) ⬇️
libp2p/transports/wstransport.nim 85.98% <100.00%> (ø)

... and 4 files with indirect coverage changes

lchenut
lchenut approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@lchenut lchenut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegomrsantos diegomrsantos merged commit c6aa085 into unstable Aug 21, 2023
9 of 10 checks passed
@diegomrsantos diegomrsantos deleted the concurrent-iwant branch August 21, 2023 14:34
diegomrsantos added a commit that referenced this pull request Oct 31, 2023
@diegomrsantos
Revert "Prevent concurrent IWANT of the same message (#943)"
0011a5e 
This reverts commit c6aa085.
diegomrsantos added a commit that referenced this pull request Nov 3, 2023
@diegomrsantos
Revert "Prevent concurrent IWANT of the same message (#943)"
1ea3f3a 
This reverts commit c6aa085
diegomrsantos added a commit that referenced this pull request Nov 3, 2023
@diegomrsantos
Revert "Prevent concurrent IWANT of the same message (#943)" (#977)
3fc1236
romanzac pushed a commit that referenced this pull request Nov 30, 2023
@diegomrsantos @romanzac
Revert "Prevent concurrent IWANT of the same message (#943)" (#977)
a19bc17
dryajov pushed a commit that referenced this pull request Dec 4, 2023
@diegomrsantos @dryajov
Revert "Prevent concurrent IWANT of the same message (#943)" (#977)
2f35824
romanzac pushed a commit that referenced this pull request Dec 13, 2023
@diegomrsantos @romanzac
Revert "Prevent concurrent IWANT of the same message (#943)" (#977)
c876904
This was referenced Jun 24, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchenut lchenut lchenut approved these changes

@Menduist Menduist Awaiting requested review from Menduist

@arnetheduck arnetheduck Awaiting requested review from arnetheduck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent concurrent IWANT of the same message
2 participants
@diegomrsantos @lchenut