Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid importing ecnist when not needed #942

Merged
merged 2 commits into from
Aug 30, 2023
Merged

avoid importing ecnist when not needed #942

merged 2 commits into from
Aug 30, 2023

Conversation

arnetheduck
Copy link
Contributor

secio can get its helpers directly from the ecnist module - but that doesn't really matter because it's also deprecated

this (significantly) reduces libp2p dependencies on bearssl speeding up compile times when not used

`secio` can get its helpers directly from the `ecnist` module - but that
doesn't really matter because it's also deprecated
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #942 (a77c787) into unstable (224f92e) will decrease coverage by 0.84%.
Report is 16 commits behind head on unstable.
The diff coverage is 11.11%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           unstable     #942      +/-   ##
============================================
- Coverage     84.32%   83.48%   -0.84%     
============================================
  Files            91       91              
  Lines         15001    15149     +148     
============================================
- Hits          12649    12647       -2     
- Misses         2352     2502     +150     
Files Changed Coverage Δ
libp2p/crypto/crypto.nim 66.49% <ø> (+3.00%) ⬆️
libp2p/crypto/ecnist.nim 70.90% <11.11%> (-2.09%) ⬇️

... and 41 files with indirect coverage changes

@arnetheduck arnetheduck merged commit b76bac7 into unstable Aug 30, 2023
8 of 10 checks passed
@arnetheduck arnetheduck deleted the avoid-ecnist branch August 30, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants