Add penalty

vacp2p · Aug 19, 2023 · 4114961 · 4114961
1 parent fab4fb7
commit 4114961
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/libp2p/protocols/pubsub/gossipsub/behavior.nim b/libp2p/protocols/pubsub/gossipsub/behavior.nim
@@ -306,7 +306,7 @@ proc checkIWANTTimeouts(g: GossipSub, timeoutDuration: Duration) {.raises: [].}
   for msgId, request in g.outstandingIWANTs.pairs():
     if currentTime - request.timestamp > timeoutDuration:
       trace "IWANT request timed out", messageID=msgId, peer=request.peer
-      # applyBehaviorPenalty(g, request.peer)
+      request.peer.behaviourPenalty += 0.1
       idsToRemove.add(msgId)
   for msgId in idsToRemove:
       g.outstandingIWANTs.del(msgId)

diff --git a/tests/pubsub/testgossipinternal.nim b/tests/pubsub/testgossipinternal.nim
@@ -817,11 +817,13 @@ suite "GossipSub internal":
 
     # Check that the message ID is in outstandingIWANTs
     check: gossipSub.outstandingIWANTs.contains(ihaveMessageId)
+    check: peer.behaviourPenalty == 0.0
 
     await sleepAsync(60.milliseconds)
 
-    # Check that the message ID has been removed from outstandingIWANTs after the timeout
+    # Check that the message ID has been removed from outstandingIWANTs after the timeout and peer has been penalized
     check: not gossipSub.outstandingIWANTs.contains(ihaveMessageId)
+    check: peer.behaviourPenalty == 0.1
 
     await allFuturesThrowing(conns.mapIt(it.close()))
     await gossipSub.switch.stop()