forked from PaulRBerg/foundry-template
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add DeploymentConfig
for network specifc deployments
#5
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
//// SPDX-License-Identifier: UNLICENSED | ||
|
||
pragma solidity >=0.8.19 <=0.9.0; | ||
|
||
import { Script } from "forge-std/Script.sol"; | ||
|
||
contract DeploymentConfig is Script { | ||
error DeploymentConfig_InvalidDeployerAddress(); | ||
error DeploymentConfig_NoConfigForChain(uint256); | ||
|
||
struct NetworkConfig { | ||
address deployer; | ||
} | ||
|
||
NetworkConfig public activeNetworkConfig; | ||
|
||
address private deployer; | ||
|
||
constructor(address _broadcaster) { | ||
if (block.chainid == 31_337) { | ||
activeNetworkConfig = getOrCreateAnvilEthConfig(); | ||
} else { | ||
revert DeploymentConfig_NoConfigForChain(block.chainid); | ||
} | ||
if (_broadcaster == address(0)) revert DeploymentConfig_InvalidDeployerAddress(); | ||
deployer = _broadcaster; | ||
} | ||
|
||
function getOrCreateAnvilEthConfig() public view returns (NetworkConfig memory) { | ||
return NetworkConfig({ deployer: deployer }); | ||
} | ||
|
||
// This function is a hack to have it excluded by `forge coverage` until | ||
// https://github.com/foundry-rs/foundry/issues/2988 is fixed. | ||
// See: https://github.com/foundry-rs/foundry/issues/2988#issuecomment-1437784542 | ||
// for more info. | ||
// solhint-disable-next-line | ||
function test() public { } | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, last question - what does the broadcast keyword specify?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
broadcast
is a modifier that wraps the function invm.startBroadcast()
andvm.stopBroadcast()
.Anything that happens inside these are tx that are broadcast to the network.
We don't want the instantiation of
DeploymentConfig()
to happen onchain, we only need it to access our configuration values.That's why I'm removing the
broadcast
from the main deploy script'srun()
function. This gives us control over which action should indeed be broadcast.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, okay!