Merge pull request #9 from uxrocket/2.x

2.x
uxrocket · Sep 16, 2015 · 814e149 · 814e149
2 parents bc4ba51 + c23b15f
commit 814e149
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 9 deletions.
diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "uxrocket.select",
-  "version": "2.8.0",
+  "version": "2.8.1",
   "homepage": "https://github.com/uxrocket/uxrocket.select",
   "authors": [
     "Bilal Çınarlı <[email protected]>"

diff --git a/lib/uxrocket.select.js b/lib/uxrocket.select.js
@@ -118,7 +118,7 @@
         }
 
         $el.after(
-            '<span class="' + ns.current + ' ' + _opts.current + '">' +
+            '<span class="' + ns.current + ' ' + ns.current + '-' + _opts.index + '  ' + _opts.current + '">' +
             '   <span class="' + ns.text + '">' + $current + '</span>' +
             '   <span class="' + ns.arrow + ' ' + _opts.arrow + '"></span>' +
             '</span>');
@@ -173,15 +173,24 @@
         });
 
         $('body').on('DOMNodeRemoved', function(e) {
-            if(e.target === $el[0]) {
-                cleanUp(_opts.index)
+            var el = $el[0];
+
+            if(e.target === el) {
+                // select replaced or removed
+                // when Select options changed, update bindings
+                // via $.uxselect.update($el) method
+                if(e.originalEvent.relatedNode !== el) {
+                    setTimeout(function() {
+                        cleanUp(_opts.index);
+                    }, 1);
+                }
             }
         });
 
     };
 
     var cleanUp = function(index) {
-        $('.' + ns.wrap + '-' + index).remove();
+        $('.' + ns.current + '-' + index).unwrap().remove();
         $('#' + ns.list + '-' + index).remove();
     };
 
@@ -303,13 +312,14 @@
             var _opts = $(this).data(ns.data),
                 optionList = builtOptions($(this)),
                 $current = setText($(this).find(':selected').text());
+
             $(this).next('.' + ns.current).find('.' + ns.text).text($current);
             $('.' + ns.list).filter('[data-select="' + $(this).attr('id') + '"]').replaceWith(optionList);
 
+            bindUIActions($(this));
+
             callback(_opts.onUpdate);
         });
-
-        bindUIActions($el);
     };
 
     // remove
@@ -349,7 +359,7 @@
     };
 
     // Version
-    ux.version = "2.8.0";
+    ux.version = "2.8.1";
 
     // settings
     ux.settings = defaults;

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "uxrocket.select",
-  "version": "2.8.0",
+  "version": "2.8.1",
   "description": "jQuery based Select box replacement function",
   "repository": {
     "type": "git",