updates applicationsById query

uwblueprint · Nov 8, 2023 · 18dd800 · 18dd800
1 parent d029ae6
commit 18dd800
Showing 1 changed file with 38 additions and 38 deletions.
diff --git a/backend/typescript/services/implementations/appDashboardService.ts b/backend/typescript/services/implementations/appDashboardService.ts
@@ -104,49 +104,49 @@ async getApplicationsById(id: number): Promise<ApplicationDTO> {
     let applications: Array<Application> | null;
     let applicationById: Application |undefined;
     let applicationByIdDTO: ApplicationDTO;
-  //   try {
-  //     applications = await Application.findAll();
-  //     applicationById =  applications.find(application => application.id == id);
+    try {
+      applications = await Application.findAll();
+      applicationById =  applications.find(application => application.id == id);
 
-  //     if (applicationById === undefined) {
-  //       // Handle the case when no application is found
-  //       throw new Error(`Application with id ${id} not found`);
-  //     }
+      if (applicationById === undefined) {
+        // Handle the case when no application is found
+        throw new Error(`Application with id ${id} not found`);
+      }
 
-  //     applicationByIdDTO = {
-  //       id: applicationById.id,
-  //       academicOrCoop: applicationById.academicOrCoop,
-  //       academicYear: applicationById.academicYear,
-  //       email: applicationById.email,
-  //       firstChoiceRole: applicationById.firstChoiceRole,
-  //       firstName: applicationById.firstName,
-  //       heardFrom: applicationById.heardFrom,
-  //       lastName: applicationById.lastName,
-  //       locationPreference: applicationById.locationPreference,
-  //       program: applicationById.program,
-  //       pronouns: applicationById.pronouns,
-  //       pronounsSpecified: applicationById.pronounsSpecified,
-  //       resumeUrl: applicationById.resumeUrl,
-  //       roleSpecificQuestions: applicationById.roleSpecificQuestions,
-  //       secondChoiceRole: applicationById.secondChoiceRole,
-  //       shortAnswerQuestions: applicationById.shortAnswerQuestions,
-  //       status: applicationById.status,
-  //       term: applicationById.term,
-  //       timesApplied: applicationById.timesApplied,
-  //       timestamp: applicationById.timestamp
-  //       };
-  //   } catch (error: unknown) {
-  //     Logger.error(
-  //       `Failed to get applications by id = ${id}. Reason = ${getErrorMessage(
-  //         error,
-  //       )}`,
-  //     );
-  //     throw error;
-  //   }
+      applicationByIdDTO = {
+        id: applicationById.id,
+        academicOrCoop: applicationById.academicOrCoop,
+        academicYear: applicationById.academicYear,
+        email: applicationById.email,
+        firstChoiceRole: applicationById.firstChoiceRole,
+        firstName: applicationById.firstName,
+        heardFrom: applicationById.heardFrom,
+        lastName: applicationById.lastName,
+        locationPreference: applicationById.locationPreference,
+        program: applicationById.program,
+        pronouns: applicationById.pronouns,
+        pronounsSpecified: applicationById.pronounsSpecified,
+        resumeUrl: applicationById.resumeUrl,
+        roleSpecificQuestions: applicationById.roleSpecificQuestions,
+        secondChoiceRole: applicationById.secondChoiceRole,
+        shortAnswerQuestions: applicationById.shortAnswerQuestions,
+        secondChoiceStatus: applicationById.secondChoiceStatus,
+        status: applicationById.status,
+        term: applicationById.term,
+        timesApplied: applicationById.timesApplied,
+        timestamp: applicationById.timestamp
+        };
+    } catch (error: unknown) {
+      Logger.error(
+        `Failed to get applications by id = ${id}. Reason = ${getErrorMessage(
+          error,
+        )}`,
+      );
+      throw error;
+    }
      return applicationByIdDTO;
   }
 
-
   async getDashboardsByApplicationId(
     applicationId: number,
   ): Promise<ApplicationDashboardDTO[]> {