Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change backend port to 8080 #188

Merged
merged 4 commits into from
Apr 8, 2024
Merged

Conversation

carolynzhang18
Copy link
Contributor

@carolynzhang18 carolynzhang18 commented Apr 8, 2024

TODO CHANGE DOCUMENTATION THING

Notion ticket link

Ticket Name

Implementation description

Steps to test

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

owen-sellner
owen-sellner previously approved these changes Apr 8, 2024
Copy link
Contributor

@owen-sellner owen-sellner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!! There is just one silly nitpick

frontend/src/components/pages/HooksDemo/HooksDemo.tsx Outdated Show resolved Hide resolved
owen-sellner
owen-sellner previously approved these changes Apr 8, 2024
achandrabalan
achandrabalan previously approved these changes Apr 8, 2024
@carolynzhang18 carolynzhang18 merged commit c8ab20e into main Apr 8, 2024
1 check passed
@carolynzhang18 carolynzhang18 deleted the carolyn/change-backend-port branch April 8, 2024 01:05
carolynzhang18 added a commit that referenced this pull request Apr 8, 2024
* Change backend port to 8080

* Run backend linter

* Restore timer value

* Add 8080

---------

Co-authored-by: Owen Sellner <[email protected]>
carolynzhang18 added a commit that referenced this pull request Apr 19, 2024
* Upgrade React, Node, and linter

* Change backend port to 8080 (#188)

* Change backend port to 8080

* Run backend linter

* Restore timer value

* Add 8080

---------

Co-authored-by: Owen Sellner <[email protected]>

---------

Co-authored-by: Owen Sellner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants