Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ruff #1

Merged
merged 5 commits into from
Oct 6, 2024
Merged

Update ruff #1

merged 5 commits into from
Oct 6, 2024

Conversation

mslwang
Copy link
Collaborator

@mslwang mslwang commented Oct 3, 2024 •
edited
Loading

Implementation description

Updated ruff spec to be more strict for better linting and formatting.

Steps to test

  1. Try running pdm run ruff check . --fix && ruff format .

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@mslwang mslwang merged commit 840633f into main Oct 6, 2024
1 check passed
@mslwang mslwang deleted the update-ruff branch October 8, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mslwang