Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add useTable hook, custom table component and refactor manage user page #67

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

98ZhaoJeffrey
Copy link
Collaborator

Notion ticket link

Ticket Name

Implementation description

  • Introduce a react hook and a custom table component for any component that uses a table

Steps to test

  1. Test that the table is functional on the manage user page

What should reviewers focus on?

  • Should we be using our own hook atp?
  • Does the structure of how I implement a custom table make sense at all?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@carolynzhang18
Copy link
Collaborator

BTW I see this eslint warning:
image

Copy link
Collaborator

@carolynzhang18 carolynzhang18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like this!! pretty clean 🤩

@mxc-maggiechen
Copy link
Collaborator

It looks good! My only feedback is maybe make the table headers bolded? There's also some weird UI stuff going on with the rows per page selector... Might be good to fix if possible 👍
image

@mxc-maggiechen mxc-maggiechen self-requested a review October 3, 2024 00:12
@98ZhaoJeffrey
Copy link
Collaborator Author

btw dont merge yet, need to do this for the other table here as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants