hashsum: Windows: check in binary mode by default and allow --binary/--text #6808
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, changed hashsum with
--check
to use the same behavior as without--check
for selecting binary/text mode, i.e. allows--binary
/--text
flags and default to binaryUpdated command line help message
Added binary test cases for hashsum. Using a PNG file since PNG header conveniently has
0x0D0A
in it. Verified the new test cases would fail on Windows without this changeCloses #6805