Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checksum: rework for improving checkum checking GNU behavior match #6654

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

checksum: rework for improving checkum checking GNU behavior match #6654

wants to merge 20 commits into from

Commits on Oct 11, 2024

  1. cksum: simplify nesting

    @RenjiSann
    RenjiSann committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    5842f14 View commit details
    Browse the repository at this point in the history

  2. checksum: Allow for non UTF-8 input

    @RenjiSann
    RenjiSann committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    ccf5559 View commit details
    Browse the repository at this point in the history

  3. test(checksum): add a test for non UTF-8 chars in comments

    @RenjiSann
    RenjiSann committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    780db80 View commit details
    Browse the repository at this point in the history

  4. test(cksum): add multiple tests 

    test(cksum): add test for blake length gessing
test(cksum): add test for hexa/base64 confusion
test(cksum): add test for error handling on incorrectly formatted checksum
test(cksum): add test for trailing spaces making a line improperly formatted
test(cksum): Re-implement GNU test 'cksum-base64' in the testsuite
    @RenjiSann
    RenjiSann committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    f6f0ed9 View commit details
    Browse the repository at this point in the history

  5. feat(checksum): extract algorithm detection in a specific file

    @RenjiSann
    RenjiSann committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    b5bb0a7 View commit details
    Browse the repository at this point in the history

  6. feat(checksum): move u8/str/OsString conversion to utils

    @RenjiSann
    RenjiSann committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    7246067 View commit details
    Browse the repository at this point in the history

  7. fix(checksum): lines should not be trimmed before regex matching

    @RenjiSann
    RenjiSann committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    c00a444 View commit details
    Browse the repository at this point in the history

  8. feat(checksum): extract line processing into a separate function

    @RenjiSann
    RenjiSann committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    4570f1b View commit details
    Browse the repository at this point in the history

  9. feat(checksum): add a ChecksumOption struct to bundle CLI flags

    @RenjiSann
    RenjiSann committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    57cd029 View commit details
    Browse the repository at this point in the history

  10. feat(checksum): extract utility functions to specific file to make lo… 

    …gic simpler
    @RenjiSann
    RenjiSann committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    0e316c2 View commit details
    Browse the repository at this point in the history

  11. feat(checksum): introduce a LineCheckError type

    @RenjiSann
    RenjiSann committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    0aeed93 View commit details
    Browse the repository at this point in the history

  12. feat(checksum): small type/docstring changes

    @RenjiSann
    RenjiSann committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    af925e6 View commit details
    Browse the repository at this point in the history

  13. feat(checksum): refactor get_expected_checksum

    @RenjiSann
    RenjiSann committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    a0b301c View commit details
    Browse the repository at this point in the history

  14. feat(checksum): extract checksum file processing in a separate function

    @RenjiSann
    RenjiSann committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    b1d0701 View commit details
    Browse the repository at this point in the history

  15. checksum: handle no-length case in algo-based BLAKE2b

    @RenjiSann
    RenjiSann committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    48531e9 View commit details
    Browse the repository at this point in the history

  16. feat(checksum): get rid of specific Base64 regex

    @RenjiSann
    RenjiSann committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    7dce4f2 View commit details
    Browse the repository at this point in the history

  17. cksum: Fix handling of both encodings in a single file

    @RenjiSann
    RenjiSann committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    cf8811d View commit details
    Browse the repository at this point in the history

  18. feat(checksum): prevent incorrectly formatted checksums from stopping… 

    … the program
    @RenjiSann
    RenjiSann committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    c9fa70f View commit details
    Browse the repository at this point in the history

  19. feat(checksum): get rid of ChecksumResult at the line level

    @RenjiSann
    RenjiSann committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    5fed16f View commit details
    Browse the repository at this point in the history

  20. checksum: handle hexadecimal/base64 confusion and retry

    @RenjiSann
    RenjiSann committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    f5f6d6c View commit details
    Browse the repository at this point in the history