install: create destination file with safer modes before copy #6595
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6435.
As is suggested by the original issue, the creation of the destination file is delegated to
fs::copy
which creates the file with default mode0644
. This makes the file readable by other users before the finalchmod
is done, which is potentially unsafe and inconsistent with GNU install.Since the current implementation unconditionally removes the destination path before the copy, creating the file with a minimal
u=rw
permission would not hurt the copy. This patch implements this (for unix).