Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all artifact arguments optional & Add assert statements to catch undefined components in system functions #98

Merged
merged 17 commits into from
Jun 25, 2022
Merged

Make all artifact arguments optional & Add assert statements to catch undefined components in system functions #98

merged 17 commits into from
Jun 25, 2022

Conversation

abeerfatima
Copy link
Contributor

No description provided.

@abeerfatima
Add assert statements to catch undefined components in system functio…
c13de02 
…n calls
@abeerfatima
Add assert statements to catch undefined components in system functio…
d170991 
…n calls #95
@abeerfatima
Add assert statements to catch undefined components in system functio…
a14c92d 
…n calls
@abeerfatima
Add assert statements to catch undefined components in system functio…
0688a6d 
…n calls #95
@abeerfatima
Add assert statements to catch undefined components in system functio…
fd67b33 
…n calls #95 and Make all artifact arguments optional #90
@abeerfatima
Add assert statements to catch undefined components in system functio…
1f2c3e1 
…n calls #95
@abeerfatima
Add assert statements to catch undefined components in system functio…
2ad3e05 
…n calls #95
@abeerfatima
Add assert statements to catch undefined components in system functio…
852976b 
…n calls #95
@abeerfatima
Add assert statements to catch undefined components in system functio…
b9fbb54 
…n calls #95
@DM1122 DM1122 self-requested a review June 23, 2022 23:51
This was linked to issues Jun 24, 2022
Make all artifact arguments optional #90
Open
Add assert statements to catch undefined components in system function calls #95
Closed
DM1122
DM1122 requested changes Jun 24, 2022
View reviewed changes
Copy link
Collaborator

@DM1122 DM1122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Take a look through my comments and let me know if you have any questions. You'll notice some comments are formatted as suggestions, which should let you automatically apply my suggestions should you deem them valid.

payload_designer/components/component.py Outdated Show resolved Hide resolved
payload_designer/components/filters.py Outdated Show resolved Hide resolved
payload_designer/systems/satellites.py Outdated Show resolved Hide resolved
payload_designer/systems/satellites.py Outdated Show resolved Hide resolved
payload_designer/luts/functions.py Outdated Show resolved Hide resolved
payload_designer/luts/functions.py Outdated Show resolved Hide resolved
payload_designer/luts/functions.py Outdated Show resolved Hide resolved
payload_designer/luts/functions.py Outdated Show resolved Hide resolved
abeerfatima and others added 8 commits June 25, 2022 11:07
@abeerfatima @DM1122
Update payload_designer/components/component.py
38b1def 
Co-authored-by: David Maranto <[email protected]>
@abeerfatima @DM1122
Update payload_designer/systems/satellites.py
6282aee 
Co-authored-by: David Maranto <[email protected]>
@abeerfatima @DM1122
Update payload_designer/systems/satellites.py
43df45b 
Co-authored-by: David Maranto <[email protected]>
@abeerfatima @DM1122
Update payload_designer/luts/functions.py
943b890 
Co-authored-by: David Maranto <[email protected]>
@abeerfatima @DM1122
Update payload_designer/luts/functions.py
01a8bac 
Co-authored-by: David Maranto <[email protected]>
@abeerfatima @DM1122
Update payload_designer/luts/functions.py
ad1db0a 
Co-authored-by: David Maranto <[email protected]>
@abeerfatima @DM1122
Update payload_designer/components/filters.py
c4a7f22 
Co-authored-by: David Maranto <[email protected]>
@abeerfatima @DM1122
Update payload_designer/luts/functions.py
11dc406 
Co-authored-by: David Maranto <[email protected]>
@abeerfatima abeerfatima changed the title First issues Make all artifact arguments optional & Add assert statements to catch undefined components in system functions Jun 25, 2022
@DM1122 DM1122 merged commit e10c8f3 into dev Jun 25, 2022
@DM1122 DM1122 deleted the first-issues branch June 25, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DM1122 DM1122 DM1122 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@abeerfatima @DM1122