Handle metrics that has no filepath #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has some conflicts with #320 . Can you try resolving them? (Try merging the two branches together to see the conflicts.) |
|
Will do. |
|
Fixed. Sorry for the delay. It took me a while to figure out what had been changed in both PRs... |
RayPlante
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: landing page crashed when metrics data didn't have filepath info.
Example: https://testdata.nist.gov/od/id/66AF4AFEA96764C4E0532457068100261895
Fix: Check filepath attribute before using it.
Testing: To test using testdata.nist.gov as backend, in environment.ts set useMetadataService: true, useCustomizationService: true and replace data.nist.gov with testdata.nist.gov.
Test samples:
http://localhost:4200/metrics/mds2-2124
http://localhost:4200/lps/mds2-2124
http://localhost:4200/metrics/576CE869311197F3E0531A570681C5C71857
http://localhost:4200/lps/576CE869311197F3E0531A570681C5C71857