-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle metrics that has no filepath #323
Conversation
This PR has some conflicts with #320 . Can you try resolving them? (Try merging the two branches together to see the conflicts.) |
Will do. |
Fixed. Sorry for the delay. It took me a while to figure out what had been changed in both PRs... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conflicts are resolved. Behavior tested and confirmed on testdata.
Issue: landing page crashed when metrics data didn't have filepath info.
Example: https://testdata.nist.gov/od/id/66AF4AFEA96764C4E0532457068100261895
Fix: Check filepath attribute before using it.
Testing: To test using testdata.nist.gov as backend, in environment.ts set useMetadataService: true, useCustomizationService: true and replace data.nist.gov with testdata.nist.gov.
Test samples:
http://localhost:4200/metrics/mds2-2124
http://localhost:4200/lps/mds2-2124
http://localhost:4200/metrics/576CE869311197F3E0531A570681C5C71857
http://localhost:4200/lps/576CE869311197F3E0531A570681C5C71857