Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore legacy datatypes #698

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

david-waltermire
Copy link
Collaborator

Committer Notes

This PR adds back the legacy camel-case data types removed in #561 and #562.

This will restore use of these types, which are still used in OSCAL.

This PR also includes:

This PR builds on the following prior PRs, which should be merged first.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

david-waltermire and others added 5 commits July 12, 2024 00:11
…check.sch as Metaschema external module constraints.
…dules and external constraints for supporting multiple models and Metapath types and functions with colliding names that are in different namespaces. This better aligns Metapath with the XPath 3.1 specification.
… to restore use of these types, which are used in OSCAL. Refactored module constraints to fix Metapath errors. Removed keyword checks in names added by usnistgov#542, which is not needed, since these names are allowed.
…will allow for more flexible organization of constraints in multiple files. Fixed metapaths in module constraints.
@david-waltermire david-waltermire force-pushed the feature/restore-legacy-datatypes branch from 9c17646 to 894b223 Compare July 24, 2024 13:00
@david-waltermire
Copy link
Collaborator Author

This should be merged using "rebase and merge" to avoid merge conflicts in downstreams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant