Feature/code cleanup and API documentation #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aces and to simplify and align implementations.
* Completed code to support Metapath array construction. * Implemented array postfix and unary lookups. * Cleaned up ISequence implementations, moving getFirstItem to be a method member. Added a utility function to convert a sequence into an array member. * Added support for the following Metapath functions: - array:get - array:put - array:append - array:subarray - array:remove - array:insert-before - array:join - array:head - array:tail - array:reverse - array:flatten * Fixed spotbugs null check warnings * Cleaned up some Javadocs. * Incorporated changes based on CodeRabbit review. * normalized line endings
* Added initial implementation of the 'metaschema-cli metapath list-functions' command. * Added a better means to collect the metaschema-related CLI commands for reuse.
… returns the root node when getValue is called.
- Support for map construction. - Added support for maps in function call, postfix and unary lookups. - Added support and unit tests for the following Metapath functions: - map:get - map:merge - map:entry - map:size - map:keys - map:contains - map:find - map:put - map:remove - Added missing characteristics on a number of existing Metapath functions. - Cleaned up a bunch of PMD warnings.
…function signatures now instead of the Java class name.
… use. Improved abstract CLI validation commands to provide more options for model detection.
david-waltermire
force-pushed
the
feature/code-cleanup-and-api-documentation
branch
2 times, most recently
from
9865492
to
61447eb
Compare
david-waltermire
force-pushed
the
feature/code-cleanup-and-api-documentation
branch
from
2d2d0e1
to
3418071
Compare
…d to distinguish provided model bindings. - Added support for capturing parsed location information in bound objects. This will be useful for producing context for validation results. - Fixed bugs causing the ordering of generated classes to be chaotic. Also fixed bugs causing binding configurations to match based on minor URI differences caused by inconsistent behavior between file and path URI productions. - Updated Metaschema module binding to incorporate latest module changes. - Added support for exposing parse locations in validation results. - Added support for producing Static Analysis Results Interchange Format (SARIF) results based on schema and constraint validation results. - Added SARIF CLI output option to validate command. - Added support for including rules and artifact information in SARIF results. SARIF files now work on commonly available viewers. - Added constraint formal-name and description to SARIF output, allowing human readers to better understand why the result was produced. - Added a GUID to SARIF output for each rule. - Adjusted constraint result production to allow for pass results to be produced, which supports producing SARIF result that include both pass and fail statuses using an API-level configuration. - Added methods to handle making URIs relative to another URI. - Ensured proper handling of Metapath errors during validation. Resolves usnistgov/oscal-cli#292 - Fixed compile and PMD warnings. - Added some Javadocs.
- Cleaned up ISource implementations, and ensured that URI-based sources are properly cached. - Added many Javadoc comments. - Lightly refactored some code and created javadocs to improve readability and reduce complexity. - Cleaned up stream closure to ensure that streams are properly closed. - Cleaned up use of some interfaces that were duplicated.
david-waltermire
force-pushed
the
feature/code-cleanup-and-api-documentation
branch
from
3418071
to
228067a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
Added many missing Javadoc comments.
Some minor code cleanup to make the code more readable.
This PR builds on the following PRs, which should be merged before this PR.
All Submissions:
Changes to Core Features: