Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(jquery): remove in prototype-nav #370

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

refactor(jquery): remove in prototype-nav #370

wants to merge 3 commits into from

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Jun 9, 2021

part of #367

@vercel
Copy link

vercel bot commented Jun 9, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/monocompany/bedrock/HCj3BqhNw1xUydxz6hp82JcS1rd3
✅ Preview: https://bedrock-git-fork-haroenv-feat-jquery-nav-monocompany.vercel.app

Haroenv
Haroenv commented Jun 9, 2021
View reviewed changes
core/js/prototype-nav.js Outdated Show resolved Hide resolved
Haroenv
Haroenv commented Jun 10, 2021
View reviewed changes
core/js/prototype-nav.js Outdated Show resolved Hide resolved
@Haroenv Haroenv requested a review from Wolfr June 10, 2021 07:08
@Wolfr
Copy link
Contributor

Wolfr commented Jun 10, 2021

Cool work 😎

@Wolfr
Copy link
Contributor

Wolfr commented Nov 29, 2021

L76 .parentElement.classList.contains('br-tree-dir--is-collapsed'); is using a jQuery method (and is also not referencing a class)

@Wolfr Wolfr mentioned this pull request Nov 29, 2021
Open
5 tasks
@Haroenv
Copy link
Contributor Author

Haroenv commented Nov 29, 2021

Feel free to reopen / merge into a temporary branch you continue on with this work (no need for credit), but I don't have the bandwidth atm to fix those cases :)

@Haroenv Haroenv closed this Nov 29, 2021
@Wolfr
Copy link
Contributor

Wolfr commented Nov 29, 2021

Yeah the comment is not for you, it's for myself :D

Feel free to ignore this repo.

@Wolfr Wolfr reopened this Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wolfr Wolfr Awaiting requested review from Wolfr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Haroenv @Wolfr