Change location of scenarios that will be deployed in docker image. #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scenarios will now be deployed from co-simulation/bundle/src/assembly/scenarios rather than from sample_scenarios.zip
|
Kudos, SonarCloud Quality Gate passed!
|
adev4a
reviewed
Nov 10, 2023
|
Should this change impact VRU at all? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scenarios will now be deployed from co-simulation/bundle/src/assembly/scenarios rather than from sample_scenarios.zip
PR Details
Description
Changes the docker build process to automatically deploy scenario files found in src/bundle/assembly/resources/scenarios instead of relying on a pre-zipped archive of scenario files.
Related GitHub Issue
Closes #175
Related Jira Key
Motivation and Context
This makes the behavior for adding a scenario more intuitive and lets us maintain scenarios as plain files instead of a zip archive.
How Has This Been Tested?
Ran locally after building fresh docker image and confirmed newly created test scenario files were deployed at /opt/carma-simulation/scenarios in the final image.
Types of changes
Checklist: