Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade kubebuilder scaffold to v3 #89

Merged
merged 34 commits into from
Aug 29, 2023
Merged

feat: upgrade kubebuilder scaffold to v3 #89

merged 34 commits into from
Aug 29, 2023

Conversation

leonsteinhaeuser
Copy link
Contributor

@leonsteinhaeuser leonsteinhaeuser commented Aug 15, 2023 •
edited
Loading

Description

This PR upgrades Kubebuilder to v3 and the project scaffold to go/v4. For more information see: https://book.kubebuilder.io/migration/legacy/v2vsv3

How Has This Been Tested?

  • unit tests
  • e2e tests

Test Configuration:

  • Kubernetes version: v1.24.15 - v1.27.3
  • Kubectl version: v1.24.15 - v1.27.3
  • Node operation system: Ubuntu 22.04

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@leonsteinhaeuser leonsteinhaeuser self-assigned this Aug 15, 2023
@leonsteinhaeuser leonsteinhaeuser changed the title feat/upgrade kubebuilder to v3 feat: upgrade kubebuilder to v3 Aug 15, 2023
@github-actions github-actions bot added size/XXL Denotes a PR that changes 2000+ lines, ignoring generated files. feature labels Aug 15, 2023
@github-actions github-actions bot added size/XL Denotes a PR that changes 1000-1999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 2000+ lines, ignoring generated files. labels Aug 15, 2023
@github-actions github-actions bot added size/L Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 1000-1999 lines, ignoring generated files. labels Aug 15, 2023
@github-actions github-actions bot added size/XL Denotes a PR that changes 1000-1999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 15, 2023
@github-actions github-actions bot added size/L Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 1000-1999 lines, ignoring generated files. labels Aug 16, 2023
@github-actions github-actions bot added size/XL Denotes a PR that changes 1000-1999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 16, 2023
@leonsteinhaeuser leonsteinhaeuser marked this pull request as ready for review August 29, 2023 11:29
@leonsteinhaeuser leonsteinhaeuser requested review from a team August 29, 2023 11:29
tom-hauschke
tom-hauschke suggested changes Aug 29, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
go.mod Show resolved Hide resolved
@leonsteinhaeuser leonsteinhaeuser merged commit a1f2652 into main Aug 29, 2023
11 checks passed
@leonsteinhaeuser leonsteinhaeuser deleted the feat/upgrade-kubebuilder-to-v3 branch August 29, 2023 14:40
@leonsteinhaeuser leonsteinhaeuser changed the title feat: upgrade kubebuilder to v3 feat: upgrade kubebuilder scaffold to v3 Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-hauschke tom-hauschke tom-hauschke approved these changes

Assignees

@leonsteinhaeuser leonsteinhaeuser

Labels
feature size/XL Denotes a PR that changes 1000-1999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leonsteinhaeuser @tom-hauschke