Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: assignment to nil map #178

Merged
merged 1 commit into from
Apr 29, 2024
Merged

fix: assignment to nil map #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/util/secret.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,12 @@ func UpdateSecret(ctx context.Context, clnt *passbolt.Client, scheme *runtime.Sc
}
}

// TODO: normally this should not be necessary because we already assigned an empty map
// TODO: for some reason, it is necessary to check if the map is nil at this point
if secret.Data == nil {
secret.Data = make(map[string][]byte)
}

switch {
// check if field is set
// if field is set, get field value from passbolt secret and set it as kubernetes secret value
Expand Down
Loading