perf(web): fast path for returning Response
#850
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally when we return a value for h3, it tries to detect the content type and prepare a response/response-init. When users directly return a
Response
object (and have not preset any other headers or status/statusCode), we can go through a fast path optimization making handling %3 to %6 faster.But there is another part in the story. When h3 is combined with other web framework handlers that always return a
Response
object, we were blindly creating anotherResponse
object because it was working based on merging.By smarty reusing the same
Response
object, we can speed up to 2x (Bun) (%25 on Node) in performances.This change also has the benefit that
onBeforeResponse
has access to the final preparedResponse
object instead of preparedResponseInit