Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move event.req and event.res to event.node.* #231

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Nov 15, 2022

Ref #73

Using soft deprecation to use event.node.req and event.node.res instead of event.req and event.res preparing users for next iterations.

A new event.path getter also added to make accessing to path easier. (used path instead of url to avoid confusing hostname inclusion)

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #231 (dac2e30) into main (dc8ee81) will decrease coverage by 0.15%.
The diff coverage is 71.91%.

@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
- Coverage   76.06%   75.90%   -0.16%     
==========================================
  Files          20       20              
  Lines        1199     1216      +17     
  Branches      224      224              
==========================================
+ Hits          912      923      +11     
- Misses        287      293       +6     
Impacted Files Coverage Δ
src/utils/cache.ts 30.61% <0.00%> (ø)
src/utils/response.ts 61.71% <58.82%> (ø)
src/router.ts 94.73% <66.66%> (ø)
src/utils/proxy.ts 86.02% <71.42%> (ø)
src/utils/body.ts 83.78% <72.72%> (ø)
src/event/event.ts 47.94% <76.19%> (+5.08%) ⬆️
src/app.ts 93.05% <100.00%> (ø)
src/error.ts 79.31% <100.00%> (ø)
src/node.ts 85.18% <100.00%> (ø)
src/utils/cookie.ts 92.06% <100.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 merged commit e2c2144 into main Nov 15, 2022
@pi0 pi0 deleted the refactor/node-ns branch November 15, 2022 11:59
@pi0 pi0 mentioned this pull request Nov 15, 2022
7 tasks
@n4an
Copy link

n4an commented Dec 9, 2022

preparing users for next iterations.

poor users, why are you so with them?
and I thought what system architects are for.

@pi0
Copy link
Member Author

pi0 commented Dec 9, 2022

Please read #73 for motives and reasons for this refactor :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants