Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C,C++: fix properties field for object defined or declared with structure definitions #3944

Merged
merged 2 commits into from
Feb 24, 2024

Conversation

masatake
Copy link
Member

With this pull request, ctags can fill properties: field of svar and fn in the input like:

static struct S { ... } svar;
static struct T { ... } fn(...) { ... }

The declaration like:

static struct T { ... } fn(...);

is not in the scope of this pull request because of the bug reported in #3943.

For the input like:

  static struct S {...} svar;

the original code didn't fill the properties: field of
svar with "static".

Signed-off-by: Masatake YAMATO <[email protected]>
Copy link

codecov bot commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.38%. Comparing base (8706976) to head (89e16c5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3944   +/-   ##
=======================================
  Coverage   85.38%   85.38%           
=======================================
  Files         234      234           
  Lines       56202    56204    +2     
=======================================
+ Hits        47987    47989    +2     
  Misses       8215     8215           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

… the return type of the function

For the input like:

    static struct S {...} fn (...) { ... }

the original code didn't fill the properties: field of
fn with "static".

Signed-off-by: Masatake YAMATO <[email protected]>
@masatake masatake merged commit 6406cb3 into universal-ctags:master Feb 24, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant