fix: Fixing non generic method OnType() on ParameterOverrides

Fixed #164
unitycontainer · Jun 5, 2020 · c523cd9 · c523cd9
1 parent 2a3a057
commit c523cd9
Showing 1 changed file with 2 additions and 14 deletions.
diff --git a/src/Dependency/Resolution/Collections/ParameterOverrides.cs b/src/Dependency/Resolution/Collections/ParameterOverrides.cs
@@ -24,19 +24,6 @@ public void Add(string key, object value)
             _values.Add(new Tuple<string, object>(key, value));
         }
 
-        ///// <summary>
-        ///// When implemented in derived classes, this method is called from the <see cref="OverrideCollection{TOverride,TKey,TValue}.Add"/>
-        ///// method to create the actual <see cref="ResolverOverride"/> objects.
-        ///// </summary>
-        ///// <param name="key">Key value to create the resolver.</param>
-        ///// <param name="value">InjectionParameterValue to store in the resolver.</param>
-        ///// <returns>The created <see cref="ResolverOverride"/>.</returns>
-        //protected override ParameterOverride MakeOverride(string key, object value)
-        //{
-        //    return new ParameterOverride(key, value);
-        //}
-
-
         #region Type Based Override
 
         /// <summary>
@@ -59,7 +46,8 @@ public ResolverOverride[] OnType<T>()
         /// <returns>The new override.</returns>
         public ResolverOverride[] OnType(Type targetType)
         {
-            return new ResolverOverride[0];
+            return _values.Select(p => new ParameterOverride(p.Item1, p.Item2).OnType(targetType))
+                          .ToArray();
         }
 
         #endregion