Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

215787 drop cash assist #4368

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from
Open

Conversation

MarekBiczysko
Copy link
Contributor

@MarekBiczysko MarekBiczysko commented Oct 24, 2024

@MarekBiczysko MarekBiczysko changed the base branch from long-term/remove-tp to develop November 6, 2024 14:26
black

black

migrations, drop generic foreign keys usage

black

fixture fix

ut, migrations

migrations merge fix

ut

migration merge fix
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 47.57709% with 238 lines in your changes missing coverage. Please review.

Project coverage is 42.71%. Comparing base (9a5a090) to head (ac25916).

Files with missing lines Patch % Lines
src/hct_mis_api/apps/payment/models.py 55.73% 54 Missing ⚠️
..._mis_api/apps/payment/migrations/0149_migration.py 32.78% 41 Missing ⚠️
src/hct_mis_api/apps/payment/schema.py 6.45% 29 Missing ⚠️
src/hct_mis_api/apps/payment/filters.py 25.00% 12 Missing ⚠️
..._mis_api/apps/payment/migrations/0150_migration.py 67.56% 12 Missing ⚠️
src/hct_mis_api/apps/payment/mutations.py 7.69% 12 Missing ⚠️
...is_api/apps/grievance/migrations/0074_migration.py 71.42% 6 Missing ⚠️
src/hct_mis_api/apps/household/models.py 0.00% 6 Missing ⚠️
...s/payment/xlsx/xlsx_verification_export_service.py 0.00% 5 Missing ⚠️
.../apps/core/management/commands/generatefixtures.py 0.00% 4 Missing ⚠️
... and 30 more

❗ There is a different number of reports uploaded between BASE (9a5a090) and HEAD (ac25916). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (9a5a090) HEAD (ac25916)
unittests 2 0
e2e 2 1
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #4368       +/-   ##
============================================
- Coverage    78.47%   42.71%   -35.76%     
============================================
  Files          944      945        +1     
  Lines        44831    44142      -689     
============================================
- Hits         35182    18857    -16325     
- Misses        9649    25285    +15636     
Flag Coverage Δ
e2e 42.71% <47.57%> (-15.23%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mmaciekk mmaciekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

frontend looks gooooood

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants