Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TP⛺️ Changes (Collector filters, Merge Ids) #4279

Draft
wants to merge 57 commits into
base: develop
Choose a base branch
from

Conversation

mmaciekk
Copy link
Contributor

@mmaciekk mmaciekk commented Oct 2, 2024

AB#220280: Backend changes for Targeting - Add a new rule group named 'Collector Rule Group'
AB#213976: Targeting - Add a new rule group named 'Collector Rule Group'

@mmaciekk mmaciekk added long-term-branch backend Changes in BE code frontend Changes in FE code labels Oct 2, 2024
@mmaciekk mmaciekk self-assigned this Oct 2, 2024
@mmaciekk mmaciekk marked this pull request as draft October 2, 2024 10:49
Maciej Szewczyk and others added 2 commits October 3, 2024 13:24
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 38.18182% with 102 lines in your changes missing coverage. Please review.

Project coverage is 55.01%. Comparing base (9a5a090) to head (beb0687).
Report is 78 commits behind head on develop.

Files with missing lines Patch % Lines
src/hct_mis_api/apps/targeting/validators.py 12.50% 42 Missing ⚠️
src/hct_mis_api/apps/targeting/mutations.py 0.00% 32 Missing ⚠️
src/hct_mis_api/apps/targeting/models.py 47.05% 18 Missing ⚠️
src/hct_mis_api/apps/targeting/graphql_types.py 75.75% 8 Missing ⚠️
...s_api/apps/targeting/services/targeting_service.py 60.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (9a5a090) and HEAD (beb0687). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (9a5a090) HEAD (beb0687)
unittests 2 0
e2e 3 1
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #4279       +/-   ##
============================================
- Coverage    78.47%   55.01%   -23.47%     
============================================
  Files          944      952        +8     
  Lines        44831    44705      -126     
============================================
- Hits         35182    24593    -10589     
- Misses        9649    20112    +10463     
Flag Coverage Δ
e2e 55.01% <38.18%> (-2.94%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szymon-kellton szymon-kellton self-assigned this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Changes in BE code frontend Changes in FE code long-term-branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants