Merge pull request #4424 from unicef/pg_changes

pg changes
unicef · Nov 11, 2024 · c64aa17 · c64aa17
2 parents b25cede + ff471b4
commit c64aa17
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/frontend/package.json b/src/frontend/package.json
@@ -1,6 +1,6 @@
 {
   "name": "frontend",
-  "version": "2.12.3",
+  "version": "2.13.0",
   "private": true,
   "type": "module",
   "scripts": {

diff --git a/src/hct_mis_api/apps/payment/services/payment_gateway.py b/src/hct_mis_api/apps/payment/services/payment_gateway.py
@@ -54,7 +54,7 @@ class PaymentInstructionStatus(Enum):
 
 class PaymentInstructionFromDeliveryMechanismPerPaymentPlanSerializer(ReadOnlyModelSerializer):
     remote_id = serializers.CharField(source="id")
-    unicef_id = serializers.CharField(source="payment_plan.unicef_id")
+    external_code = serializers.CharField(source="payment_plan.unicef_id")
     fsp = serializers.SerializerMethodField()
     payload = serializers.SerializerMethodField()
     extra = serializers.SerializerMethodField()
@@ -78,24 +78,24 @@ class Meta:
         model = DeliveryMechanismPerPaymentPlan
         fields = [
             "remote_id",
-            "unicef_id",
+            "external_code",
             "fsp",
             "payload",
             "extra",
         ]
 
 
 class PaymentInstructionFromSplitSerializer(PaymentInstructionFromDeliveryMechanismPerPaymentPlanSerializer):
-    unicef_id = serializers.SerializerMethodField()  # type: ignore
+    external_code = serializers.SerializerMethodField()  # type: ignore
 
-    def get_unicef_id(self, obj: Any) -> str:
+    def get_external_code(self, obj: Any) -> str:
         return f"{obj.payment_plan.unicef_id}-{obj.order}"
 
     class Meta:
         model = PaymentPlanSplit
         fields = [
             "remote_id",
-            "unicef_id",
+            "external_code",
             "fsp",
             "payload",
             "extra",
@@ -210,7 +210,7 @@ def get_transferred_status_based_on_delivery_amount() -> str:
 @dataclasses.dataclass()
 class PaymentInstructionData(FlexibleArgumentsDataclassMixin):
     remote_id: str
-    unicef_id: str
+    external_code: str
     status: str  # "DRAFT"
     fsp: str
     system: int