Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 turn off express-http-proxy's keep alive #1612

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

stormslowly
Copy link
Member

@stormslowly stormslowly commented Sep 25, 2024

.

Summary by CodeRabbit

  • 新功能
    • 在代理配置中添加了 proxyTimeout 属性,设置为 50000 毫秒。
    • 引入了 proxyReqOptDecorator 方法,用于修改代理的请求选项,禁用保持活动功能。

Copy link
Contributor

coderabbitai bot commented Sep 25, 2024

Walkthrough

此次更改涉及对 packages/bundler-mako/index.js 文件中 dev 函数的修改。新增了 proxyTimeout 属性,设置为 50000 毫秒。同时引入了 proxyReqOptDecorator 函数,用于修改代理的请求选项,具体包括通过将 proxyReqOptsagent 属性设置为 false 来禁用保持活动功能。过滤器函数保持不变,仍然只允许 GET 和 HEAD 请求。

Changes

文件路径 更改摘要
packages/bundler-mako/index.js 添加 proxyTimeout 属性和 proxyReqOptDecorator 方法,修改代理配置。

Possibly related PRs

Suggested reviewers

  • sorrycc

Poem

在兔子洞里跳跃欢,
新增功能真不简单。
代理超时五万毫,
请求选项也更新。
让我们一起欢呼吧,
代码更美好,兔子乐无边! 🐇✨


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3be3c79 and d4915e8.

Files selected for processing (1)
  • packages/bundler-mako/index.js (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • packages/bundler-mako/index.js

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.94%. Comparing base (68de8e2) to head (d4915e8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1612   +/-   ##
=======================================
  Coverage   61.93%   61.94%           
=======================================
  Files         128      128           
  Lines       15405    15405           
=======================================
+ Hits         9541     9542    +1     
+ Misses       5864     5863    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stormslowly stormslowly merged commit e48ff2a into master Sep 25, 2024
21 checks passed
@stormslowly stormslowly deleted the fix/504_keep_alive branch September 25, 2024 04:00
@stormslowly
Copy link
Member Author

close #1609

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants