Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use picocolors instead chalk #1597

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wChenonly
Copy link

@wChenonly wChenonly commented Sep 14, 2024

use picocolors

  1. reduce node_module size
  2. improve performance

#1593 It was accidentally turned off.

Summary by CodeRabbit

  • 新功能

    • 更新终端输出样式,采用 picocolors 库替代 chalk,提升控制台信息的可读性和视觉效果。
  • 修复

    • 更改错误消息的格式化方式,确保在黑名单中找到包时的输出更清晰。

Copy link
Contributor

coderabbitai bot commented Sep 14, 2024

Important

Review skipped

Review was skipped due to path filters

Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

此次更改主要涉及将项目中的 chalk 依赖替换为 picocolors,以实现终端输出的颜色格式化。所有相关文件中,控制台消息的样式更新为使用 picocolors,并在 package.json 中添加了新的依赖项。整体功能未发生变化,主要是对输出样式的改进。

Changes

文件 更改摘要
package.json 添加了依赖项 "picocolors": "^1.1.0"
packages/bundler-mako/index.js chalk 替换为 picocolors,更新 getDevBannercheckConfig 函数中的控制台消息。
packages/bundler-mako/package.json 移除了 "chalk": "^4.1.2",添加了 "picocolors": "^1.1.0"
packages/mako/package.json 移除了 chalk,添加了 picocolors 作为依赖。
packages/mako/src/checker.ts chalk 替换为 picocolors,更新错误消息的格式。
packages/mako/src/cli.ts chalk 替换为 picocolors,更新 Mako 应用程序版本的输出样式。
scripts/test-hmr.mjs chalk 替换为 picocolors,更新测试名称和错误日志的输出格式。
scripts/test-utils.js chalk 替换为 picocolors,更新控制台输出样式的相关代码。

Possibly related PRs

Poem

🐇 在终端中跳跃的小兔子,
颜色鲜艳如彩虹般美丽,
picocolors 来了,替代了 chalk
输出变得更加生动,
让每个消息都闪烁着光辉,
兔子们欢呼,快乐无比! 🌈


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sorrycc
Copy link
Member

sorrycc commented Sep 14, 2024

Why is the change in the pnpm lock file so big, are you using pnpm 8? (8 is the right version, don't use 9)

@sorrycc
Copy link
Member

sorrycc commented Sep 14, 2024

ci broken, please run just ready locally before commit.

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.11%. Comparing base (75118d5) to head (9bdc696).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1597   +/-   ##
=======================================
  Coverage   62.11%   62.11%           
=======================================
  Files         129      129           
  Lines       15559    15559           
=======================================
  Hits         9665     9665           
  Misses       5894     5894           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wChenonly
Copy link
Author

Why is the change in the pnpm lock file so big, are you using pnpm 8? (8 is the right version, don't use 9)

yes, I'm using 9 and it's already taken care of.

@wChenonly
Copy link
Author

ci broken, please run just ready locally before commit.

image

It seems that it should be caused by biome. At the time of pnpm install, the version may have been promote. Can we improve the version of biome.json and configure

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants