feat(px2rem): support nesting_selector #1064

LovePlayCode · 2024-04-18T10:10:38Z

支持nesting_selector

Summary by CodeRabbit

New Features
- Added support for attribute and pseudo-class selectors in CSS parsing.
- Tests added to cover new selector types.

coderabbitai · 2024-04-18T10:10:56Z

Walkthrough

The changes in this update aimed to enhance the CSS selector support in the css_px2rem module. New functions were introduced to handle attribute and pseudo-class selectors, enriching the parsing capabilities for these selector types. Additionally, the logic for handling nesting selectors was improved to incorporate whitelist and blacklist configurations.

Changes

File	Summary
crates/mako/src/visitors/css_px2rem.rs	Added support for `AttributeSelector` and `PseudoClassSelector`, updated selector parsing logic, and improved nesting selector handling.

Poem

Among the code's intricate trance,
Selectors now gracefully prance.
Attributes and pseudo-classes find their way,
Tests ensure they're here to stay.
CodeRabbit leaps in glee, a new feature ballet! 🐇🌟

Note

Pull Request Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai

Commits

Files that changed from the base of the PR and between b61eae2 and 088c975.

Files selected for processing (1)

crates/mako/src/visitors/css_px2rem.rs (3 hunks)

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

stormslowly · 2024-04-19T01:43:33Z

crates/mako/src/visitors/css_px2rem.rs

+ assert_eq!(
+ run(
+ r#".a .b{width:100px;}"#,
+ Px2RemConfig {


用 Default::default() 或者 Px2RemConifg::default()
更加简洁

收到确实是这样更简洁

stormslowly · 2024-04-19T02:20:30Z

建议看下这个部分 https://swc.rs/docs/plugin/ecmascript/cheatsheet#make-your-handlers-stateless
再修改下状态对应的状态的

    current_decl: Option<String>,
    current_selectors: Vec<String>,

current_decl 的记录是有问题的
current_selectors 感觉是不是可以边visit边判断。如果不满足了 block 部分就可以不用 visitor 了

stormslowly · 2024-04-19T02:26:00Z

crates/mako/src/visitors/css_px2rem.rs

@@ -173,6 +186,28 @@ fn parse_compound_selector(selector: &CompoundSelector) -> String {
 result
 }

+fn parse_attribute(attr: &AttributeSelector) -> String {


一般来说把"文本"变成对应的抽象数据结构叫 parse，这里是抽象数据结构到 String 不应该叫 parse
xxx_to_string 应该更合适一点。
另外看看 AttributeSelector 是不是已经有 trait 可以直接转换成 string 的

通过 span 到 CM 取出片段我觉得是更加合理的实现
self.context.meta.css.cm.span_to_source()

# Conflicts: # crates/mako/src/visitors/css_px2rem.rs

sorrycc · 2024-04-24T09:36:32Z

场景可能暂用不到，这个 pr 先 hold 不合。

谦男 added 6 commits April 17, 2024 14:57

feat: 完成css_rem属性选择器

25fd442

feat: 支持伪类选择器

3e4e993

feat: 完成nest

e1215f1

Merge branch 'px2rem_nest' into master_temp

cf206f0

fix: 去除 log

eefe6b7

feat: 完成nest选择器

b61eae2

stormslowly reviewed Apr 19, 2024

View reviewed changes

sorrycc added 2 commits April 24, 2024 15:01

Merge commit '7696d3b075e010732948f8388d611680e7245b25' into master_temp

12b5028

# Conflicts: # crates/mako/src/visitors/css_px2rem.rs

chore: code style

088c975

sorrycc changed the title ~~支持nesting_selector~~ feat(px2rem): support nesting_selector Apr 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(px2rem): support nesting_selector #1064

feat(px2rem): support nesting_selector #1064

LovePlayCode commented Apr 18, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 18, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

stormslowly Apr 19, 2024 •

edited

Loading

LovePlayCode Apr 23, 2024

stormslowly commented Apr 19, 2024

stormslowly Apr 19, 2024

stormslowly Apr 19, 2024

sorrycc commented Apr 24, 2024 •

edited

Loading

feat(px2rem): support nesting_selector #1064

Are you sure you want to change the base?

feat(px2rem): support nesting_selector #1064

Conversation

LovePlayCode commented Apr 18, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Apr 18, 2024 • edited Loading

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

stormslowly Apr 19, 2024 • edited Loading

Choose a reason for hiding this comment

LovePlayCode Apr 23, 2024

Choose a reason for hiding this comment

stormslowly commented Apr 19, 2024

stormslowly Apr 19, 2024

Choose a reason for hiding this comment

stormslowly Apr 19, 2024

Choose a reason for hiding this comment

sorrycc commented Apr 24, 2024 • edited Loading

LovePlayCode commented Apr 18, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 18, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

stormslowly Apr 19, 2024 •

edited

Loading

sorrycc commented Apr 24, 2024 •

edited

Loading