Caching SVG doesn't cache CSS class name and Viewbox settings #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Honestly, I'm pretty confident about this PR but it shouldn't be merged yet. I'm not sure how best to test it. The unit tests all pass but I failed to create new unit tests as I couldn't work out how to mock the AppCache correctly. Any ideas how to do this? Do you also have an existing method of testing this on a 'real' site, or should I work something out for that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue where caching an SVG with a class name (or Viewbox setting) causes the class name to be contained in the cache. If outputting the same SVG later includes the class name from the first usage.
This PR splits the caching so that the file read is independently cached from the Css class name and Viewbox settings.