Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes timolins/react-hot-toast#367 from upstream
I've had a look and found out that this fix only works correctly if you remove all toasts, which
toast.remove
does as it's overloaded (undefined removes all). Actually I would preferremoveById
, but that's another discussion.I found out that what is not happening is that when you click 'remove' the PAUSE_END action is not fired (onMouseLeave is not triggered).
Either fire this action on remove and dismiss, or extract the logic of this PAUSE_END into a separate function and reuse.
You need to do this because the current fix does not count on the
pauseDuration
being adjusted. This is revealed when you remove by id and then they all disappear at once after the largest pause, which is not the desired behaviour.Finally, this is a really tricky bug because `dismiss' is also affected, but because dismiss hides the toast, you accidentally trigger END_PAUSE because wrapper is there and onMouseLeave triggers.