L96 GitHub working patch to rxjs 6 #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding in "error reporting" to describe what exactly this resource is for. This project makes validation errors super easy to report!
Add "error reporting" to description
…“ngErrors” selector
Plunker link wasn't opening with the live preview option pre-selected.
update "Live demo" href
Fix project name and clone URL in CONTRIBUTING.md
- changes dependencies for rxjs
- changes dependencies for rxjs
-installed rxjs-compat -updated typescript to 2.9.2 -added web pack -added tsconfig.json to fix ts errors including yarn example throwing errors "Error: Final loader didnt return a Buffer or String" -changed many methods that to newer standard like of, combineLatest, map, etc -adds rxjs-tslint module and tslint.json to lint the projects to rxjs 6 -ran tslint rxjs-lint with to change old rxjs imports
-installed rxjs-compat -updated typescript to 2.9.2 -added web pack -added tsconfig.json to fix ts errors including yarn example throwing errors "Error: Final loader didnt return a Buffer or String" -changed many methods that to newer standard like of, combineLatest, map, etc -adds rxjs-tslint module and tslint.json to lint the projects to rxjs 6 -ran tslint rxjs-lint with to change old rxjs imports
|
would be great to have support for RxJS 6. Currently can't use it in Angular 7. Anyone know of a workaround ? thanks |
You can use rxjs-compat during the time where you wait the approval of this PR ;) |
|
If you want: https://www.npmjs.com/package/@hackages/ngxerrors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you adding/fixing?
Attempting to make it compatible with rxjs version 6, mostly using rxjs-compat.
Have you added tests for your changes?
Not yet. Unfortunately didn't have enough time.
Will this need documentation changes?
No, although the changes are on how rxjs imports are structured and the new ways of using its components (e.g. combineLatest, Observable, Subject, map, etc). There is plenty of docs describing the changes. (https://auth0.com/blog/whats-new-in-rxjs-6/), but that doesn't directly concern this package
Does this introduce a breaking change?
So far none apparent. I am currently using it in a project almost in production.
Other information
I ran the example with
yarn exampleand tested it, had no errors on the console. Had to update the code to support the braking changes of rxjs 6, other than a few warnings (as you can see in the screenshots) I have not come across any problem. I am also testing as much as I can on the project in which I am using it on, hope it helps.