Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coastal #1

Merged
merged 22 commits into from
Aug 9, 2024
Merged

Coastal #1

merged 22 commits into from
Aug 9, 2024

Conversation

maddenp-noaa
Copy link
Contributor

An initial UW coupled driver, for the Coastal app.

maddenp-noaa
maddenp-noaa commented Aug 8, 2024
View reviewed changes
coastal/coastal.jsonschema Show resolved Hide resolved
coastal/environment.yml Show resolved Hide resolved
coastal/Makefile Show resolved Hide resolved
coastal/coastal.yaml Show resolved Hide resolved
@maddenp-noaa maddenp-noaa marked this pull request as ready for review August 8, 2024 17:29
WeirAE
WeirAE approved these changes Aug 8, 2024
View reviewed changes
Copy link

@WeirAE WeirAE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been following all the work and thanks for all of the progress! LGTM

christinaholtNOAA
christinaholtNOAA approved these changes Aug 8, 2024
View reviewed changes
Copy link

@christinaholtNOAA christinaholtNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell.

NaureenBharwaniNOAA
NaureenBharwaniNOAA reviewed Aug 9, 2024
View reviewed changes
Copy link

@NaureenBharwaniNOAA NaureenBharwaniNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason my review was left in pending. I'll leave these comments and see where they are at now.

coastal/README.md Outdated Show resolved Hide resolved
coastal/coastal.py Show resolved Hide resolved
elcarpenterNOAA
elcarpenterNOAA approved these changes Aug 9, 2024
View reviewed changes
Copy link

@elcarpenterNOAA elcarpenterNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maddenp-noaa maddenp-noaa merged commit 3d917e9 into ufs-community:main Aug 9, 2024
1 check passed
@maddenp-noaa maddenp-noaa deleted the coastal branch August 9, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NaureenBharwaniNOAA NaureenBharwaniNOAA NaureenBharwaniNOAA left review comments

@christinaholtNOAA christinaholtNOAA christinaholtNOAA approved these changes

@WeirAE WeirAE WeirAE approved these changes

@elcarpenterNOAA elcarpenterNOAA elcarpenterNOAA approved these changes

@fgabelmannjr fgabelmannjr Awaiting requested review from fgabelmannjr fgabelmannjr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maddenp-noaa @christinaholtNOAA @WeirAE @NaureenBharwaniNOAA @elcarpenterNOAA