-
Notifications
You must be signed in to change notification settings - Fork 0
Home
Rob Knight edited this page Mar 4, 2022
·
47 revisions
Meeting notes are below. Goals & milestones are here.
- Rob: PR for setting site title and page titles
-
.alignfull
class is shifted too far left
- Further reduce the redundant template parts files since they aren't necessary for content areas
- CampusPress has our account info for the theme and plugins repo
- CampusPress is still on WP 5.8.3. We need them to upgrade to 5.9 to support our theme.
- Initial performance test on CP network is disappointing. We're going to need a huge improvement or news and the homepage will have to live elsewhere.
- Name the two stylesheets properly for their contexts (we were able to use just one sheet for both)
- Test the 'one sass partial per core block' setup (this should work just fine)
- We made sure the editor enqueues the same sass partials as the front end.
- We will go forward assuming that we will have an individual sass partial file for each core block only when we need to change it.
- We learned that
theme.json
has the final say in the style cascade, in both the front and the back end of the site.
- Home page templates wrap the site title in an
<h1>
tag. All other page templates wrap the site title in a<p>
tag.- Why? Because the home page typically doesn't have a discrete
h1
. All other pages do. Also, you are on the home page, so the site title is a logicalh1
when no otherh1
is on the page. - In WCMS, we have the same problem. We opted for site titles always being in
<p>
tags. That means only home pages don't have a properh1
tag, and all sub pages do.
- Why? Because the home page typically doesn't have a discrete
- We've entered a re-factoring stage. Important to clean up in prep for the next phase.
- Focus on sass files, templates, and linting sass, PHP, and HTML files.
- Release betas with standard-version:
standard-version --release-as 1.0.0-beta.V
where 'V' is the beta number. - Refactored the header files to pull out the campus page top region into a separate template part.
- Jason found an official way™ 😆 for modifying block output in PHP before it is rendered.
- The other header template parts can also be refactored to remove redundant parts
- Need a build script to create the installable theme folder
- Jason organizing and abstracting templates and parts according to the latest block theme standards:
- Abstract parts out and create sub-templates only when need is obvious (logo display differences between campus home and subsites)
- Name template abstractions for widest use case
- ✅
header-subsite.html
rather than - 🛑
header-department.html
- ✅
- First release on 2022-02-04
- Theme release process:
-
standard-version
locally to bump version and create/update the CHANGELOG - Create a zipped folder of the built theme files for WordPress users to download
- Push to Github and include tags
- Create a pre-release (title is the tag) and attach working build
- Save the release (Slack will be notified 🎉)
-
- Pull content creation functions from theme
- Include a
wordpress.xml
file along with the theme that creates a couple of pages, posts, and menus, and puts them in the correct spots in the theme. - Treat this as a first-run experience for new theme users who may or may not be in CampusPress.
- Include a
- Automatic page "About this theme" (We're changing this)
- Shove footer to bottom
- Remove title from home page template
- Gap in some flexed objects (menus in global header)
- Walk through the front versus back end CSS.
- Deployment strategy
- Patterns workflow: how do we create/customize patterns for the block editor interface
- Sample content (in a WordPress.xml file)
- Individual block theming workflow
- Add a folder for blocks
- One CSS/SCSS file for each block
- Enqueue block styles in
functions.php
once for each block, so WP knows which custom styles to load on a page.
- Capturing feedback from team and from users (web form -> GH issues AND structured issue creation)
- Development workflow added to README:
- Have Docker running and wp-env installed.
- In your themes subfolder,
gh repo clone ucsc/theme-ucsc ucsc
- In the ucsc folder,
npm install && npm run build
to compile theme file -
cd
to root folder and runwp-env start
- Login (
admin:password
) and navigate to http://localhost:8888/wp-admin/import.php
- Whether or not to have specific home page template? Not yet, but can do if it seems necessary