chore: lighten fallback pcolor for wallpapers on bluefin #1808
+32,117
−303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
Raindrac
changed the title
Raindrac
changed the title
castrojo
approved these changes
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request lightens the pcolor of every wallpaper added by Bluefin, changing them all to #464646. Previously, most wallpapers had the pcolor set to #000000. Although effective at conveying the lack of a wallpaper, it was disorienting and the color blended into the top bar. Lightening the color eliminates the disorienting feeling, and it even matches the color of the shell's search bar.
Ideally, users will never see the pcolor in the first place. But if a wallpaper is ever moved/removed, or if a glitch occurs, it'll at least be obvious what's happening without being so disorienting.
Yeah, this is a kinda minor change. Very minor, even. 😛
This pull request requires #1806 to be merged first.