Allow the user to configure the auto-capitalization and auto-correction for chat messages. #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 1, 2017 18:43
…input field configurable.
…uired to show multi line pastes properly. Some keyboards (SwiftKey) refuse to disable auto-capitalization if the multi line flag is also set, but this should be considered a bug in those keyboards.
…not sending the multi line flag to the IME.
zopieux
reviewed
Jan 4, 2017
| <CheckBoxPreference android:key="volumebtn_size" android:title="@string/pref_volumebtn_size" android:summary="@string/pref_volumebtn_size_summary" android:defaultValue="true" /> | ||
| <CheckBoxPreference android:key="autocorrect_input" android:title="@string/pref_autocorrect_enable" android:defaultValue="true" /> | ||
| <CheckBoxPreference android:key="autocapitalize_input" android:title="@string/pref_autocapitalize_enable" android:defaultValue="true" /> | ||
| <CheckBoxPreference android:key="volumebtn_size" android:title="@string/pref_volumebtn_size" android:summary="@string/pref_volumebtn_size_summary" android:defaultValue="true" /> |
There was a problem hiding this comment.
Minor whitespace issue there.
|
As noted on IRC, the auto-correction toggle seems to be less useful than the auto-capitalization one. I added it because someone requested it, but it might make more sense to leave this as a global setting for the keyboard rather than allowing users to specifically disable it for weechat-android. |
mauritsd
commented
Jan 4, 2017
|
is this still relevant? |
oakkitten
force-pushed
the
master
branch
2 times, most recently
from
3789f56
to
199d6cc
Compare
|
I would like to be able to disable auto-capitalization. Edit: This might just be tied to my keyboard app's settings, though? |
|
I don't think I have auto-capitalization and I'm just using Gboard, it has a setting for that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two preferences to allow the user to disable auto-correction and auto-capitalization on the chat message input EditText. To work around a SwiftKey bug/feature we set multi line mode (InputType.TYPE_TEXT_FLAG_MULTI_LINE) on the ActionEditText but don't actually send it on to the IME itself.