Refactored and tested SerializeForLogging #6456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 28 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
jakobht
commented
Oct 31, 2024
3vilhamster
reviewed
Oct 31, 2024
| } | ||
|
|
||
| func (f *simpleRequestLogWrapper) SerializeForLogging() (string, error) { | ||
| if f.request == nil || reflect.ValueOf(f.request).IsNil() { |
There was a problem hiding this comment.
This is a bit inefficient, but this is a minor thing in comparison to the next json.Marshal, so should be fine to use
There was a problem hiding this comment.
Agreed, I added a comment outlining this
jakobht
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Shaddoll
approved these changes
Nov 1, 2024
timl3136
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Refactored SerializeForLogging so we use a wrapper instead of implementing it on every single request type. The function is used to give people implementing custum authorizers the ability to log the request body.
We supported nil receivers in the old interface, so to not break this support we here support typed nils.
Why?
Improve code quality and test coverage
How did you test it?
Potential risks
Release notes
Documentation Changes