Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mutable state builder coverage #6454

Merged
merged 9 commits into from
Oct 31, 2024
Merged

mutable state builder coverage #6454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e263242
adds some coverage for the mutable state builder's reset
davidporter-id-au Oct 29, 2024
1293d33
additional case
davidporter-id-au Oct 29, 2024
65d12eb
Small amount of coverage added
davidporter-id-au Oct 29, 2024
eafa166
Merge branch 'master' into feature/msb-coverage-v
davidporter-id-au Oct 29, 2024
0e12a6e
more tests
davidporter-id-au Oct 30, 2024
8bab069
linty
davidporter-id-au Oct 30, 2024
9383cb6
WIP
davidporter-id-au Oct 30, 2024
5e886f0
Merge branch 'master' into feature/msb-coverage-v
davidporter-id-au Oct 31, 2024
cf2b4db
fmt
davidporter-id-au Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 9 additions & 23 deletions service/history/execution/mutable_state_builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,10 +143,9 @@ type (
// TODO: persist this to db
appliedEvents map[string]struct{}

insertTransferTasks []persistence.Task
insertCrossClusterTasks []persistence.Task
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not used, dead code

insertReplicationTasks []persistence.Task
insertTimerTasks []persistence.Task
insertTransferTasks []persistence.Task
insertReplicationTasks []persistence.Task
insertTimerTasks []persistence.Task

workflowRequests map[persistence.WorkflowRequest]struct{}

Expand Down Expand Up @@ -1348,12 +1347,6 @@ func (e *mutableStateBuilder) AddTransferTasks(
e.insertTransferTasks = append(e.insertTransferTasks, transferTasks...)
}

func (e *mutableStateBuilder) AddCrossClusterTasks(
crossClusterTasks ...persistence.Task,
) {
e.insertCrossClusterTasks = append(e.insertCrossClusterTasks, crossClusterTasks...)
}

// TODO convert AddTimerTasks to prepareTimerTasks
func (e *mutableStateBuilder) AddTimerTasks(
timerTasks ...persistence.Task,
Expand All @@ -1374,10 +1367,6 @@ func (e *mutableStateBuilder) DeleteTransferTasks() {
e.insertTransferTasks = nil
}

func (e *mutableStateBuilder) DeleteCrossClusterTasks() {
e.insertCrossClusterTasks = nil
}

func (e *mutableStateBuilder) DeleteTimerTasks() {
e.insertTimerTasks = nil
}
Expand Down Expand Up @@ -1483,10 +1472,9 @@ func (e *mutableStateBuilder) CloseTransactionAsMutation(
NewBufferedEvents: e.updateBufferedEvents,
ClearBufferedEvents: e.clearBufferedEvents,

TransferTasks: e.insertTransferTasks,
CrossClusterTasks: e.insertCrossClusterTasks,
ReplicationTasks: e.insertReplicationTasks,
TimerTasks: e.insertTimerTasks,
TransferTasks: e.insertTransferTasks,
ReplicationTasks: e.insertReplicationTasks,
TimerTasks: e.insertTimerTasks,

WorkflowRequests: convertWorkflowRequests(e.workflowRequests),

Expand Down Expand Up @@ -1563,10 +1551,9 @@ func (e *mutableStateBuilder) CloseTransactionAsSnapshot(
SignalInfos: convertPendingSignalInfos(e.pendingSignalInfoIDs),
SignalRequestedIDs: convertStringSetToSlice(e.pendingSignalRequestedIDs),

TransferTasks: e.insertTransferTasks,
CrossClusterTasks: e.insertCrossClusterTasks,
ReplicationTasks: e.insertReplicationTasks,
TimerTasks: e.insertTimerTasks,
TransferTasks: e.insertTransferTasks,
ReplicationTasks: e.insertReplicationTasks,
TimerTasks: e.insertTimerTasks,

WorkflowRequests: convertWorkflowRequests(e.workflowRequests),

Expand Down Expand Up @@ -1675,7 +1662,6 @@ func (e *mutableStateBuilder) cleanupTransaction() error {
e.nextEventIDInDB = e.GetNextEventID()

e.insertTransferTasks = nil
e.insertCrossClusterTasks = nil
e.insertReplicationTasks = nil
e.insertTimerTasks = nil

Expand Down
Loading
Loading