Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve coverage for list workflow handlers #6451

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

Shaddoll
Copy link
Contributor

What changed?

  • Move list workflow handlers to a separate file
  • Refactor list workflow handlers
  • Improve unit test coverage for list workflow handlers

Why?
Improve code quality

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 65.43536% with 131 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@115a0da). Learn more about missing BASE report.
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
service/frontend/api/list_workflow_handlers.go 51.66% 102 Missing and 29 partials ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
service/frontend/api/handler.go 71.20% <ø> (ø)
service/frontend/api/request_validator.go 100.00% <100.00%> (ø)
service/frontend/api/list_workflow_handlers.go 51.66% <51.66%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 115a0da...d93d41d. Read the comment docs.

@Shaddoll Shaddoll merged commit 13312ea into uber:master Oct 31, 2024
19 of 20 checks passed
@Shaddoll Shaddoll deleted the test2 branch October 31, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants