Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tested SerializeForLogging for all known types implementing it #6447

Closed
wants to merge 1 commit into from
Closed

Tested SerializeForLogging for all known types implementing it #6447

wants to merge 1 commit into from

Conversation

jakobht
Copy link
Contributor

@jakobht jakobht commented Oct 30, 2024

What changed?
Wrote tests for SerializeForLogging for all known structs implementing it

Why?
Improve test coverage

How did you test it?

Potential risks

Release notes

Documentation Changes

@codecov Codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.08%. Comparing base (40003fc) to head (8b22914).
Report is 16 commits behind head on master.

Additional details and impacted files

see 11 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40003fc...8b22914. Read the comment docs.

@jakobht jakobht closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shaddoll Shaddoll Awaiting requested review from Shaddoll Shaddoll will be requested when the pull request is marked ready for review Shaddoll is a code owner

@neil-xie neil-xie Awaiting requested review from neil-xie neil-xie will be requested when the pull request is marked ready for review neil-xie is a code owner

@davidporter-id-au davidporter-id-au Awaiting requested review from davidporter-id-au davidporter-id-au will be requested when the pull request is marked ready for review davidporter-id-au is a code owner

@Groxx Groxx Awaiting requested review from Groxx Groxx will be requested when the pull request is marked ready for review Groxx is a code owner

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng will be requested when the pull request is marked ready for review shijiesheng is a code owner

@3vilhamster 3vilhamster Awaiting requested review from 3vilhamster 3vilhamster will be requested when the pull request is marked ready for review 3vilhamster is a code owner

@sankari165 sankari165 Awaiting requested review from sankari165 sankari165 will be requested when the pull request is marked ready for review sankari165 is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx will be requested when the pull request is marked ready for review dkrotx is a code owner

@taylanisikdemir taylanisikdemir Awaiting requested review from taylanisikdemir taylanisikdemir will be requested when the pull request is marked ready for review taylanisikdemir is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender will be requested when the pull request is marked ready for review demirkayaender is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jakobht