Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds slightly more coverage for mutable-state-builder. #6443

Merged
merged 6 commits into from
Oct 30, 2024
Merged

Adds slightly more coverage for mutable-state-builder. #6443

merged 6 commits into from
Oct 30, 2024

Conversation

davidporter-id-au
Copy link
Contributor

@davidporter-id-au davidporter-id-au commented Oct 29, 2024 •
edited
Loading

What changed?

  • Minor refactor of some table-tests in the mutable-state-builder test code to reduce the duplication of setting up a bunch of mocks and their corresponding assertions.
  • slightly more coverage for mutable state builder

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

@codecov Codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.76%. Comparing base (5b096d1) to head (8bab069).
Report is 9 commits behind head on master.

Additional details and impacted files

see 5 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b096d1...8bab069. Read the comment docs.

@davidporter-id-au davidporter-id-au enabled auto-merge (squash) October 30, 2024 00:07
Shaddoll
Shaddoll reviewed Oct 30, 2024
View reviewed changes
Copy link
Contributor

@Shaddoll Shaddoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated: you have another PR approved but not merged. It now has conflicts with other PRs, when are you merging that one?

@davidporter-id-au
Copy link
Contributor Author

unrelated: you have another PR approved but not merged. It now has conflicts with other PRs, when are you merging that one?

good catch, I had forgotten about it. It can merge in, I'll resolve conflicts with either this or the other PR as needed

@davidporter-id-au davidporter-id-au merged commit e412f8a into uber:master Oct 30, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shaddoll Shaddoll Shaddoll approved these changes

@neil-xie neil-xie Awaiting requested review from neil-xie neil-xie is a code owner

@Groxx Groxx Awaiting requested review from Groxx Groxx is a code owner

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng is a code owner

@jakobht jakobht Awaiting requested review from jakobht jakobht is a code owner

@3vilhamster 3vilhamster Awaiting requested review from 3vilhamster 3vilhamster is a code owner

@sankari165 sankari165 Awaiting requested review from sankari165 sankari165 is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@taylanisikdemir taylanisikdemir Awaiting requested review from taylanisikdemir taylanisikdemir is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidporter-id-au @Shaddoll