Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for error cases in workflow_commands.go #6442

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

neil-xie
Copy link
Contributor

@neil-xie neil-xie commented Oct 29, 2024

What changed?
Add more tests to cover missing flags and error cases

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.43%. Comparing base (a79482f) to head (baf91e8).
Report is 23 commits behind head on master.

Additional details and impacted files
Files with missing lines Coverage Δ
tools/cli/utils.go 60.43% <100.00%> (+3.54%) ⬆️

... and 51 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a79482f...baf91e8. Read the comment docs.

@neil-xie neil-xie changed the title Add more tests for missing flags cases Add more tests for error cases in workflow_commands.go Oct 30, 2024
@neil-xie neil-xie merged commit 5af23ef into uber:master Oct 30, 2024
20 checks passed
@neil-xie neil-xie deleted the CDNC-11017 branch October 30, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants