Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mock ESProcessor and unit test to start and stop indexer #6423

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

timl3136
Copy link
Contributor

What changed?
Add mock ESProcessor and unit test to start and stop indexer

Why?
Improve test coverage

How did you test it?
Unit test

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.79%. Comparing base (b8f6da5) to head (c845261).
Report is 5 commits behind head on master.

Additional details and impacted files
Files with missing lines Coverage Δ
service/worker/indexer/indexer.go 29.78% <ø> (+20.74%) ⬆️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8f6da5...c845261. Read the comment docs.

@timl3136 timl3136 merged commit 040e28e into uber:master Oct 28, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants