Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for RegisterDomain, ListDomain and DescribeDomain #5886

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

abhishekj720
Copy link
Contributor

What changed?
Tests:

  • Register domain
  • List domain
  • describe domain

Why?
As part of test coverage week

How did you test it?
Unit test

Potential risks
Tests to avoid risk

Release notes
N.A.

Documentation Changes
Not required

@coveralls
Copy link

coveralls commented Apr 7, 2024

Pull Request Test Coverage Report for Build 018ebe8d-19ba-480d-b6de-a22689b9b54d

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 52 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+0.03%) to 67.248%

Files with Coverage Reduction New Missed Lines %
service/history/task/transfer_standby_task_executor.go 2 86.6%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
common/persistence/sql/sqlplugin/postgres/db.go 2 80.0%
service/matching/db.go 2 73.23%
common/membership/hashring.go 2 82.23%
common/log/tag/tags.go 3 50.74%
service/history/queue/timer_gate.go 3 95.83%
service/history/task/task_util.go 4 75.14%
service/history/task/fetcher.go 4 85.05%
Totals Coverage Status
Change from base Build 018ebc81-3e94-4220-aba5-c4077acfd4fc: 0.03%
Covered Lines: 98048
Relevant Lines: 145801

💛 - Coveralls

Copy link

codecov bot commented Apr 7, 2024

Codecov Report

Merging #5886 (50fd549) into master (88a4dea) will increase coverage by 0.14%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88a4dea...50fd549. Read the comment docs.

@abhishekj720 abhishekj720 merged commit 994eb7c into uber:master Apr 8, 2024
18 checks passed
@abhishekj720 abhishekj720 deleted the testh3 branch April 8, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants