Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added handler tests and transmissionHandler mock to generate cases #5884

Merged
merged 6 commits into from
Apr 6, 2024

Conversation

abhishekj720
Copy link
Contributor

What changed?
Added

  • Tests for Register Domain
  • Mock for transmission task handler

Why?
As part of code coverage week

How did you test it?
Unit Test

abhishekj720 and others added 4 commits April 5, 2024 18:20
What changed?

Covered most of the branches in history client
Why?

To ensure correctness and bump coverage

How did you test it?

unit test
Copy link

codecov bot commented Apr 6, 2024

Codecov Report

Merging #5884 (9d04634) into master (edcaf4f) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
Files Coverage Δ
common/domain/transmissionTaskHandler.go 93.44% <ø> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edcaf4f...9d04634. Read the comment docs.

@abhishekj720 abhishekj720 changed the title Added transmissionHandler mock to generate cases Added handler tests and transmissionHandler mock to generate cases Apr 6, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018eb110-1c58-4b67-88f7-4699eb4b65ae

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 73 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.003%) to 67.258%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
service/history/execution/mutable_state_util.go 2 78.13%
common/membership/hashring.go 2 82.23%
common/persistence/historyManager.go 2 66.67%
common/task/fifo_task_scheduler.go 3 84.54%
service/history/queue/timer_gate.go 3 95.83%
common/types/shared.go 4 39.91%
service/history/task/transfer_standby_task_executor.go 6 87.01%
service/history/execution/mutable_state_builder.go 7 70.08%
common/testing/history_event_util.go 21 87.95%
Totals Coverage Status
Change from base Build 018eb107-4939-4992-90a4-8071d05eda7e: -0.003%
Covered Lines: 98183
Relevant Lines: 145979

💛 - Coveralls

@abhishekj720 abhishekj720 enabled auto-merge (squash) April 6, 2024 02:09
@abhishekj720 abhishekj720 merged commit 9024217 into uber:master Apr 6, 2024
20 checks passed
@abhishekj720 abhishekj720 deleted the testh2 branch April 6, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants