Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more unit test for history client #5883

Merged
merged 2 commits into from
Apr 6, 2024

Conversation

shijiesheng
Copy link
Contributor

What changed?

  • Covered most of the branches in history client

Why?

To ensure correctness and bump coverage

How did you test it?

unit test

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Merging #5883 (96dd681) into master (5a0a853) will increase coverage by 0.07%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
Files Coverage Δ
client/history/peer_resolver.go 100.00% <ø> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a0a853...96dd681. Read the comment docs.

@shijiesheng shijiesheng merged commit edcaf4f into uber:master Apr 6, 2024
18 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018eb0f1-bfaa-4f35-adba-4e6a0db300dc

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 75 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+0.009%) to 67.269%

Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 77.62%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/task/parallel_task_processor.go 2 93.06%
common/peerprovider/ringpopprovider/config.go 2 81.58%
common/task/fifo_task_scheduler.go 2 85.57%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/matching/taskListManager.go 2 79.7%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
service/history/task/transfer_active_task_executor.go 3 72.64%
service/history/task/fetcher.go 4 85.05%
Totals Coverage Status
Change from base Build 018eb0bc-a329-4f58-96b3-3c5a5f543f54: 0.009%
Covered Lines: 98199
Relevant Lines: 145979

💛 - Coveralls

abhishekj720 pushed a commit to abhishekj720/cadence that referenced this pull request Apr 6, 2024
What changed?

Covered most of the branches in history client
Why?

To ensure correctness and bump coverage

How did you test it?

unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants